Fix ACL ICMP rules #1471
Merged
Fix ACL ICMP rules #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
|
Please add VPP integration test case for ACLs that verifies this behaviour. |
ondrej-fabry
requested changes
Sep 17, 2019
|
@ondrej-fabry this bug was caught by our robot tests (a test case fixed by @samelias which was bugged before and did not test what it should) so we already have a test entity. Also, please do not mark commit with request changes if there are no changes really requested, it's confusing. |
Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
ondrej-fabry
approved these changes
Sep 18, 2019
VladoLavor
added a commit
to VladoLavor/vpp-agent
that referenced
this pull request
Oct 4, 2019
* Fix ACL ICMP rules Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * Added integration test case Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed in all supported VPP versions:
Signed-off-by: Vladimir Lavor vlavor@cisco.com