-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add stats poller service for retrieving VPP stats #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
- move telemetry handler for vpp stats to vppcalls - add method for retrieving system stats to vppcalls API - define FallbackToCli variable Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
golangcibot
reviewed
Oct 4, 2019
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
ondrej-fabry
force-pushed
the
telemetry-update
branch
from
October 4, 2019 12:04
5520045
to
7ca8964
Compare
ondrej-fabry
changed the title
feat: Periodic polling for interface stats [WIP]
feat: Stats poller service for retrieving VPP stats [WIP]
Oct 4, 2019
golangcibot
reviewed
Oct 4, 2019
ondrej-fabry
changed the title
feat: Stats poller service for retrieving VPP stats [WIP]
feat: Add stats poller service for retrieving VPP stats [WIP]
Oct 4, 2019
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
ondrej-fabry
changed the title
feat: Add stats poller service for retrieving VPP stats [WIP]
feat: Add stats poller service for retrieving VPP stats
Oct 4, 2019
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
rewenset
reviewed
Oct 4, 2019
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
VladoLavor
approved these changes
Oct 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
VladoLavor
pushed a commit
to VladoLavor/vpp-agent
that referenced
this pull request
Oct 18, 2019
* Update govpp Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Split stats and CLI telemetry handlers - move telemetry handler for vpp stats to vppcalls - add method for retrieving system stats to vppcalls API - define FallbackToCli variable Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Update ifplugin for govpp changes Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Add StatsPoller service for retrieving stats periodically Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Begin PollStats with polling not period delay Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Validate poll period Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix vpp integration test for telemetry Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix closing channel Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.