Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add stats poller service for retrieving VPP stats #1495

Merged
merged 8 commits into from
Oct 5, 2019

Conversation

ondrej-fabry
Copy link
Member

No description provided.

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
- move telemetry handler for vpp stats to vppcalls
- add method for retrieving system stats to vppcalls API
- define FallbackToCli variable

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry ondrej-fabry added ⚡️ feature 🚧 WIP do not merge! work in progress! project/nsm labels Oct 4, 2019
@ondrej-fabry ondrej-fabry self-assigned this Oct 4, 2019
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry ondrej-fabry changed the title feat: Periodic polling for interface stats [WIP] feat: Stats poller service for retrieving VPP stats [WIP] Oct 4, 2019
@ondrej-fabry ondrej-fabry changed the title feat: Stats poller service for retrieving VPP stats [WIP] feat: Add stats poller service for retrieving VPP stats [WIP] Oct 4, 2019
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry ondrej-fabry changed the title feat: Add stats poller service for retrieving VPP stats [WIP] feat: Add stats poller service for retrieving VPP stats Oct 4, 2019
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry ondrej-fabry removed the 🚧 WIP do not merge! work in progress! label Oct 4, 2019
Copy link
Collaborator

@VladoLavor VladoLavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ondrej-fabry ondrej-fabry merged commit f3ed152 into ligato:dev Oct 5, 2019
@ondrej-fabry ondrej-fabry deleted the telemetry-update branch October 7, 2019 06:58
VladoLavor pushed a commit to VladoLavor/vpp-agent that referenced this pull request Oct 18, 2019
* Update govpp

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Split stats and CLI telemetry handlers

- move telemetry handler for vpp stats to vppcalls
- add method for retrieving system stats to vppcalls API
- define FallbackToCli variable

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Update ifplugin for govpp changes

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Add StatsPoller service for retrieving stats periodically

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Begin PollStats with polling not period delay

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Validate poll period

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Fix vpp integration test for telemetry

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Fix closing channel

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants