Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Retrieve method for descriptor in iptables plugin #1585

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

rewenset
Copy link
Contributor

Noticed I've forgot to git add this changes yesterday. Comments fixing is the most important part in here :)

  • Switch back to the default namespace asap.
    problem PR fixes:
    if d.ipTablesHandler.ListRules() returns error, call continue and skip switching to default network ns.
  • Return early if no rule chain is present.
    problem PR fixes:
    check if if goRoutinesCnt == 0 and it could happen only if correlate is empty. Set it to 1 and call retrieveRuleChains anyway.

@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #1585 into dev will increase coverage by 3.88%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #1585      +/-   ##
=========================================
+ Coverage   50.21%   54.1%   +3.88%     
=========================================
  Files         673     370     -303     
  Lines       79720   31150   -48570     
=========================================
- Hits        40032   16853   -23179     
+ Misses      37165   12939   -24226     
+ Partials     2523    1358    -1165
Flag Coverage Δ
#e2e ?
#unittests 54.1% <ø> (-0.01%) ⬇️

@ondrej-fabry ondrej-fabry changed the title refactor: Retrieve method for descriptor in iptables plugin refactor: Retrieve method for descriptor in iptables plugin Dec 10, 2019
@ondrej-fabry ondrej-fabry merged commit b6a507b into ligato:dev Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants