fix: Fix IPv4 link-local IP address handling #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rastislav Szabo <raszabo@cisco.com>
Codecov Report
@@ Coverage Diff @@
## master #1715 +/- ##
==========================================
- Coverage 59.16% 57.93% -1.24%
==========================================
Files 603 370 -233
Lines 48502 30148 -18354
==========================================
- Hits 28698 17467 -11231
+ Misses 16843 11235 -5608
+ Partials 2961 1446 -1515
Flags with carried forward coverage won't be shown. Click here to find out more. |
ondrej-fabry
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A check in Delete operation in interface_address descriptor was preventing deletion of IPv4 link-local addresses (from the 169.254.0.0/16 range). That was causing multiple IPv4 addresses applied on a single interface after subsequent update operations.
This check only makes sense for IPv6 link-local addresses, which are auto-assigned by VPP on IPv6-enabled interfaces.
Signed-off-by: Rastislav Szabo raszabo@cisco.com