Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Symfony 5 and newer PHP versions #32

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

iambrosi
Copy link

This is done by fixing deprecations regarding the TreeBuilder and by switching to Prophecy for mocks in tests, to avoid getting the error about calling the deprecated method ReflectionType::__toString().

These tests now support PHP 7.2, 7.3 and 7.4, as there no error about calling the deprecated method ReflectionType::__toString();
@coveralls
Copy link

coveralls commented Jan 19, 2020

Coverage Status

Coverage decreased (-0.3%) to 95.956% when pulling 9393900 on iambrosi:symfony5 into 8c5613d on lightSAML:master.

@iambrosi iambrosi requested a review from tmilos January 20, 2020 14:24
@iambrosi
Copy link
Author

@tmilos Would you please take a look and tell me what you think?

@matyax
Copy link

matyax commented Jan 30, 2020

Bump for interest +1

@iambrosi
Copy link
Author

@tmilos Any news on this?

@titospeakap
Copy link

any updates?

@wizhippo
Copy link

Symfony 5+ support would be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants