support Scala 2.12.16 (and 2.12.17 nightlies) #313
Conversation
| public JournalPolicies$ () { throw new RuntimeException(); } | ||
| } | ||
| - public akka.persistence.testkit.ProcessingPolicy.DefaultPolicies<akka.persistence.testkit.JournalOperation>.PassAll$ DefaultPolicy () ; | ||
| + public void akka$persistence$testkit$EventStorage$_setter_$DefaultPolicy_$eq (akka.persistence.testkit.ProcessingPolicy.DefaultPolicies<akka.persistence.testkit.JournalOperation>.PassAll x$1) ; |
There was a problem hiding this comment.
shouldn't this have been marked ACC_SYNTHETIC? I guess not important for this PR but a potential upstream problem
| * Static reference to the singleton instance of this Scala object. | ||
| */ | ||
| public static final JournalPolicies$ MODULE$ = null; | ||
| + public akka.persistence.testkit.ProcessingPolicy.DefaultPolicies<akka.persistence.testkit.JournalOperation>.PassAll$ PassAll () { throw new RuntimeException(); } |
There was a problem hiding this comment.
This method doesn't seem to show up in javap, so it looks like a bug in genjavadoc that this now shows up?
|
I guess we can merge this anyway, since we're not releasing for 2.12.17 yet. |
|
@raboof I'll investigate issues you raise (good eye!), but they aren't new in 2.12.16; I just copied the patch file from the 2.12.15 release. (I'll need to do some digging to figure out which 2.12.x version(s) were the actual starting point.) given that, I suggest you go ahead and release anyway, and if my investigation determines that we need to make changes to genjavadoc, we'll do that later. |
|
oh, I see that you did publish 👍 okay, I'll get back to this |
aah didn't notice that - great if you can look into it!
agreed, already done! |
|
so it turns out that the two questionable methods are there even in given that, I'm not motivated to investigate further. if it had been something that changed in Scala in the last 1–2 years, say, I might have been interested because I'd want to see if it was a Scala regression. but this looks more like a quality problem with genjavadoc. unless it's showing up in the Akka docs and confusing actual users, it doesn't seem worth digging into further |
No description provided.