Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make testkit part of SDK instead of generated from codegen #80

Closed
octonato opened this issue Jul 2, 2021 · 2 comments · Fixed by #339
Closed

Make testkit part of SDK instead of generated from codegen #80

octonato opened this issue Jul 2, 2021 · 2 comments · Fixed by #339
Assignees
@pvlugter
Labels
javascript-sdk kalix-runtime Runtime and SDKs sub-team

Comments

@octonato
Copy link
Member

octonato commented Jul 2, 2021

The javascript codegen generates a testkit for value entities and event sourced entities that are very similar to Akka's EventSourcedBehaviorTestkit.

Instead of generating this over and over, we should make it part of the SDK itself.
@ennru ennru added the kalix-runtime Runtime and SDKs sub-team label Jul 7, 2021
This was referenced May 19, 2022
Merged
Closed
@pvlugter
Copy link
Member

Could also introduce a separate testkit package, rather than including in the SDK, so that it can be a dev dependency only.

@pvlugter pvlugter self-assigned this May 23, 2022
@pvlugter
Copy link
Member

Testkit should be the typed version of the mock entities, for TypeScript support.

This was referenced May 23, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pvlugter pvlugter

Labels
javascript-sdk kalix-runtime Runtime and SDKs sub-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add testkit package pvlugter/kalix-javascript-sdk
3 participants
@pvlugter @ennru @octonato