feat: generic components, handlers, and contexts #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
approved these changes
May 19, 2022
| "@kalix-io/kalix-javascript-sdk": "file:../../../sdk/kalix-io-kalix-javascript-sdk-0.0.0.tgz", | ||
| "google-protobuf": "^3.11.4", | ||
| "grpc": "^1.24.9" | ||
| "@kalix-io/kalix-javascript-sdk": "1.0.0-M6" |
There was a problem hiding this comment.
Do we have some ci-trixery that anyway tests against current "snapshot" of the SDK?
There was a problem hiding this comment.
Yes. Similar setup to the Java/Scala SDKs — has the latest released version in the samples, but then updated to a locally built version in CI. Builds the SDK, scripts, and codegen, and then installs them for each sample. For example:
kalix-javascript-sdk/.circleci/config.yml
Lines 226 to 232 in 50563b8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #320.
Make components (and their command handlers and contexts) generic over state and events. Type parameters have defaults, to have the same untyped behaviour as before, and to be compatible with previous code.
Update the codegen to use the typed components, and to have the right types for serialised messages (currently needs to be proto interface + reflective message, until #326).
The typed components included in the template and samples (under
kalix.d.ts) have been removed.Update samples to make use of the new typed components and codegen. The included testkits (in the template and samples) have been updated (and should be moved into the SDK or a separate testkit dependency, #80, #168).
Will push up as separate commits, to have CI run on each set of changes, and check that samples and tests are still compatible with the SDK and codegen changes.