fix: unhandled error on testkit shutdown #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm hoping this will fix an unhandled error on testkit shutdown. I believe there is a race condition, the proxy container gets shutdown, and then immediately after the SDK will be shutdown. This will cause the connections between the two to close, but the proxy container might attempt to reconnect. This I think triggers TestContainers to throw an uncaught exception, which mocha fails on. So, we have to wait for the proxy container to shutdown before shutting down the SDK, to ensure it won't attempt to reconnect.
jroper
force-pushed
the
fix-unhandled-error-on-testkit-shutdown
branch
from
c97c725
to
a31015d
Compare
|
Integration tests passed three times in CI, good sign. |
pvlugter
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #265.
I'm hoping this will fix an unhandled error on testkit shutdown. I believe there is a race condition, the proxy container gets shutdown, and then immediately after the SDK will be shutdown. This will cause the connections between the two to close, but the proxy container might attempt to reconnect. This I think triggers TestContainers to throw an uncaught exception, which mocha fails on.
So, we have to wait for the proxy container to shutdown before shutting down the SDK, to ensure it won't attempt to reconnect.