fix: metadata export and default empty entries #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octonato
approved these changes
Mar 30, 2022
|
I guess this is good to go even during the renaming efforts. So, I will just merge it. |
johanandren
pushed a commit
that referenced
this pull request
Mar 30, 2022
Merged
johanandren
added a commit
that referenced
this pull request
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata module was being exported in place of just the Metadata class. Also make the entries parameter optional with default empty array in the jsdoc type declaration.
Metadata tests import directly from the source file, and Metadata is not used in the samples (which do use the SDK), so not currently covered by tests. Suggests that being able to import the SDK exports in the tests would be useful — these go through some processing though, given the current setup. Could also extend a sample to make use of metadata. Just manually verified for now.