chore: convert action to TypeScript #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
javascript-sdk
kalix-runtime
johanandren
approved these changes
Apr 19, 2022
| this.streamDebug('cancel invoked when already cancelled.'); | ||
| } else { | ||
| this.call.cancel(); | ||
| // FIXME: there doesn't seem to be any server-side cancel, only client-side, so what was this doing before? | ||
| // call.cancel(); |
There was a problem hiding this comment.
Hmmm. Tried looking into the grpc-js interfaces but I can't find anything suitable-cancel-like either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #293. Convert action and action-support to TypeScript.
Trying to be a direct and faithful translation of what's there. Not sure the test coverage would pick up on everything.
With the way that the contexts for unary and streamed calls are created and used, have forced expectations with some casts and non-null assertions.
There was also a
cancelon the streaming in, but there is no cancel on these server-side interfaces, so I've commented that out for now. Thecancelmethod should be removed from the streaming-in context, if cancelling is only client-side.