rename: some remaining akkaserverless to kalix renaming #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation
pvlugter
commented
Apr 27, 2022
| @@ -99,7 +99,7 @@ object EntityServiceSourceGenerator { | |||
| val typedefPath = | |||
| sourceDirectory.toAbsolutePath | |||
| .relativize(generatedSourceDirectory.toAbsolutePath) | |||
| .resolve(service.fqn.name.toLowerCase()) | |||
| .resolve(entity.fqn.name.toLowerCase()) | |||
There was a problem hiding this comment.
small fix, the generated files use the entity name not the service name, typedef imports were wrong
| @@ -16,7 +16,7 @@ | |||
| "yargs": "^17.0.1" | |||
| }, | |||
| "bin": { | |||
| "create-kalix-entity": "" | |||
| "create-kalix-entity": "create-kalix-entity.js" | |||
There was a problem hiding this comment.
this was important, otherwise the create-kalix-entity doesn't work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs https://github.com/lightbend/kalix-proxy/issues/1234
Noticed that there were still a few mentions of Akka Serverless. Also a couple of small fixes on the codegen side.
And the test proto descriptors used for codegen were also outdated, using akkaserverless annotations — not sure why the tests were still successful. Haven't looked closer at this, but have re-generated these, as they came up in searching for akkaserverless.