Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert view to TypeScript #311

Merged
merged 1 commit into from
May 2, 2022

Conversation

pvlugter
Copy link
Member

@pvlugter pvlugter commented Apr 28, 2022

Refs #293. Draft, based on #310.

With using a typed protocol now, it also uncovered a couple of things that were outdated with the latest view changes.

@pvlugter pvlugter marked this pull request as ready for review May 2, 2022 00:45
@pvlugter
Copy link
Member Author

pvlugter commented May 2, 2022

Rebased and ready for review now.

Copy link
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johanandren johanandren merged commit 3c472a4 into lightbend:main May 2, 2022
@pvlugter pvlugter deleted the typescript-view branch May 2, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants