Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Removing no reply #312

Merged
merged 9 commits into from
May 3, 2022
Merged

feat: Removing no reply #312

merged 9 commits into from
May 3, 2022

Conversation

franciscolopezsancho
Copy link
Contributor

References #718

@franciscolopezsancho
no reply to empty reply
1d8a734 
setting reply instead of null in action reply and renaming no reply to empty reply

test passing

akkaserverless-framework integration test passing
@franciscolopezsancho
Merge branch 'main' of github.com:lightbend/kalix-javascript-sdk into…
3e63249 
… removing-no-reply
@github-actions github-actions bot added Documentation Improvements or additions to documentation javascript-sdk kalix-runtime Runtime and SDKs sub-team typescript-sdk labels Apr 28, 2022
@franciscolopezsancho
Copy link
Contributor Author

waiting on https://github.com/lightbend/kalix-proxy/pull/1399 to be released

@franciscolopezsancho franciscolopezsancho changed the title Removing no reply feat: Removing no reply Apr 28, 2022
@franciscolopezsancho franciscolopezsancho marked this pull request as ready for review May 3, 2022 14:10
jrudolph
jrudolph approved these changes May 3, 2022
View reviewed changes
Copy link

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as by my superficial knowledge about the javascript sdk.

@franciscolopezsancho
Copy link
Contributor Author

Thanks, @jrudolph. I doubt might knowledge is any deeper :)

@franciscolopezsancho franciscolopezsancho merged commit 3be9cd8 into lightbend:main May 3, 2022
@franciscolopezsancho franciscolopezsancho deleted the removing-no-reply branch May 3, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrudolph jrudolph jrudolph approved these changes

Assignees
No one assigned
Labels
Documentation Improvements or additions to documentation javascript-sdk kalix-runtime Runtime and SDKs sub-team typescript-sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franciscolopezsancho @jrudolph