feat: make replicated data types generic #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvlugter
force-pushed
the
generic-replicated-data
branch
from
1339db7
to
f302794
Compare
pvlugter
commented
May 11, 2022
| @@ -35,7 +35,7 @@ export interface TypedJson { | |||
| export type Serializable = | |||
| | protobuf.Message | |||
| | TypedJson | |||
| | any | |||
| | object | |||
There was a problem hiding this comment.
This change means that Serializable is no longer always just any. The handlers and callbacks can't use the Serialiable union type directly now, as it would require the implementation to accept all these types. Entities and their handlers and contexts will also become generic, with a parameter that extends Serializable instead.
johanandren
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #320.
Make replicated data types generic. Replicated entity state is not yet generic, so this is just the underlying step towards that. Entities may need a bit of reworking to have this ripple through the contexts in particular.
The typing for serialized state is still awkward in TypeScript, with it requiring the reflective Message type, but should be able to improve on this and use the generated protobuf directly (see #326).
The type parameters will default to
Serializableto have the same behaviour as before. Some tests are updated, others left as is.Note that this used single letter type parameters at first (
T,E,K,Vand so on), but the latest TypeScript docs are now using full names, so I've followed the full name convention here as well.