fix: testkit mock command handling on failures #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
javascript-sdk
kalix-runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #347
Make the fix for when the message is undefined on failures. Add tests for the mock entities to test this.
Make the test example services shared between tests and integration tests. Codegen and kalix-scripts is a bit awkward to use here still, as it doesn't yet support TypeScript and makes some other assumptions — so generate the type declarations manually and commit these files too. Entities in the JS SDK also support async command handlers, which the codegen doesn't generate for currently. Mock command handling will also need to be async. Will make those changes separately.