Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SDK version docs update to release template #356

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Add SDK version docs update to release template #356

merged 1 commit into from
Jun 9, 2022

Conversation

beritou
Copy link
Contributor

@beritou beritou commented Jun 9, 2022

No description provided.

ennru
ennru approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to add that here!

@ennru ennru merged commit 9edd876 into lightbend:main Jun 9, 2022
@pvlugter
Copy link
Member

Just a note that we shouldn't really have that version in the main docs (also not needed for JVM SDKs). The latest version attribute is automatically written when publishing the docs:

kalix-javascript-sdk/docs/Makefile

Lines 31 to 32 in 9edd876

bin/version.sh | xargs -0 printf ":kalix-javascript-sdk-version: %s" \
> "${managed_partials}/attributes.adoc"

Would be better to use that one, rather than a manually managed version. May still be there because of the JS quickstarts being in the main docs rather than in the SDK docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beritou @pvlugter @ennru