Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid failing silently when publishing codegen #434

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

efgpinto
Copy link
Member

Fix #433

I could not test this locally to confirm which curl version is included but upgraded to latest ubuntu version which is very likely to contain the required curl version 7.76.0.

I know we are already using this ubuntu version in other places. Let me know if you think this is a bad idea.

@efgpinto efgpinto merged commit def9d83 into main Nov 14, 2022
@efgpinto efgpinto deleted the efgpinto/dont-fail-silently branch November 14, 2022 18:10
@pvlugter
Copy link
Member

Can rerun a job with SSH access in CircleCI, to try things out on the actual test machine.

@efgpinto
Copy link
Member Author

Can rerun a job with SSH access in CircleCI, to try things out on the actual test machine.

Ok, I thought you could only rerun if the pipeline failed... but now I see one can actually do it even if it passes. Good to know 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circle CI silently failing to publish codegen images
3 participants