Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump proxy to 1.0.28 #437

Merged
merged 1 commit into from
Dec 13, 2022
Merged

chore: Bump proxy to 1.0.28 #437

merged 1 commit into from
Dec 13, 2022

Conversation

johanandren
Copy link
Contributor

Copy link
Member

@pvlugter pvlugter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but looks like some unrelated TypeScript error showing up in CI:

node_modules/@types/node/globals.d.ts:72:13 - error TS2403: Subsequent variable declarations must have the same type.  Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; }'.

72 declare var AbortSignal: {
               ~~~~~~~~~~~

  node_modules/typescript/lib/lib.dom.d.ts:2071:13
    2071 declare var AbortSignal: {
                     ~~~~~~~~~~~
    'AbortSignal' was also declared here.


Found 1 error in node_modules/@types/node/globals.d.ts:72

@johanandren
Copy link
Contributor Author

Looks like mismatch between typescript and dependencies, but I didn't touch the TS version here? ( microsoft/TypeScript#51567 )

@pvlugter
Copy link
Member

Rebased on #438 changes

@pvlugter pvlugter merged commit 1c6c998 into main Dec 13, 2022
@pvlugter pvlugter deleted the wip-bump-proxy-1.0.28 branch December 13, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants