Introducing: Leady McBreadcrumbs #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a documentation site is contained within an enclosing website it's very pleasant if the breadcrumbs allows one to navigate back up. This introduces this as a first class concept within Paradox.
|
Nice. LGTM. |
|
I wonder if we could properly support "template extensions" like this. Making it easier to extend, or add new features. Same for connecting sbt settings to directives. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a documentation site is contained within an enclosing website it's very pleasant if the breadcrumbs allows one to navigate back up.
This introduces this as a first class concept within Paradox.
Despite how nicely Paradox is coded, I had a little trouble figuring out how to implement this. Please consider this a first draft and I very much welcome feedback, including feedback about how to completely re-do this. The only thing I'm happy with is that it achieves the end goal (in the test).