Merge pull request #43 from lightclient/no-throw

core/vm: fail instead of throw in non-zero extvalue

core/vm/eips.go

@@ -231,13 +231,17 @@ func opAuthCall(pc *uint64, interpreter *EVMInterpreter, callContext *callCtx) (
 	// Pop other call parameters.
 	addr, value, extValue, inOffset, inSize, retOffset, retSize := stack.pop(), stack.pop(), stack.pop(), stack.pop(), stack.pop(), stack.pop(), stack.pop()
 	// Nonzero extValue not allowed in London
-	if extValue.Cmp(uint256.NewInt()) != 0 {
-		return nil, ErrExtValueNonZero
-	}
 	toAddr := common.Address(addr.Bytes20())
 	// Get the arguments from the memory.
 	args := callContext.memory.GetPtr(int64(inOffset.Uint64()), int64(inSize.Uint64()))
 
+	// If extValue is non-zero, fail immediately.
+	if !extValue.IsZero() {
+		temp.Clear()
+		stack.push(&temp)
+		return nil, nil
+	}
+
 	var bigVal = big0
 	if !value.IsZero() {
 		gas += params.CallStipend

core/vm/errors.go

@@ -40,7 +40,6 @@ var (
 	ErrInvalidRetsub            = errors.New("invalid retsub")
 	ErrReturnStackExceeded      = errors.New("return stack limit reached")
 	ErrNoAuthorizedAccount      = errors.New("authorized account not set")
-	ErrExtValueNonZero          = errors.New("authcall extvalue nonzero")
 )
 
 // ErrStackUnderflow wraps an evm error when the items on the stack less