Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/catalyst: require withdrawals on V2 #23

Closed
wants to merge 34 commits into from
Closed

eth/catalyst: require withdrawals on V2 #23

wants to merge 34 commits into from

Conversation

MariusVanDerWijden
Copy link
Collaborator

@MariusVanDerWijden MariusVanDerWijden commented Dec 17, 2022 •
edited
Loading

If withdrawal functionality is activated, client software MUST return an INVALID status with the appropriate latestValidHash if payload.withdrawals is null. Similarly, if the functionality is not activated, client software MUST return an INVALID status with the appropriate latestValidHash if payloadAttributes.withdrawals is not null. Blocks without withdrawals MUST be expressed with an explicit empty list [] value. Refer to the validity conditions for engine_newPayloadV1 to specification of the appropriate latestValidHash value.

see https://github.com/ethereum/execution-apis/blob/main/src/engine/specification.md#specification-1

lightclient and others added 30 commits November 29, 2022 18:21
@lightclient
core/types: add withdrawal type
774be0e
@lightclient
core/beacon: add withdrawals and make types version agnostic
c27745f
@lightclient
eth/catalyst,les/catalyst: add withdrawals and make types version agn…
994b761 
…ostic
@lightclient
miner: add withdrawals and update catalyst types
a512496
@lightclient
consensus: process withdrawals
7d7fb2f
@lightclient
core/state_processor: finalize with withdrawals
58218c9
@lightclient
core/chain_makers: add withdrawal support
72ec036
@lightclient
core/block_validator: verify withdrawals root
2ebb038
@lightclient
core/rawdb: update block readers with new block format
a6e56c5
@lightclient
eth: add p2p support for withdrawals
a5853bb
@lightclient
cmd/evm: support withdrawals in t8n and b11r
9ad8070
@lightclient @marioevz
eth/downloader: always use WithBody2 when constructing blocks
97c2474 
Co-authored-by: lightclient <lightclient@protonmail.com>
Co-authored-by: marioevz <marioevz@gmail.com>
@lightclient
eth/fetcher: always use WithBody2 when constructing blocks
256e54c
@MariusVanDerWijden @lightclient
params: core: enable shanghai based on timestamps
7a817ba
@MariusVanDerWijden @lightclient
params: nitpicks
858ac2f
@lightclient
core,consensus: use timestamp based is shanghai check
798a3e4
@lightclient
consensus: fail if running shanghai on clique or ethash
0f30e74
@MariusVanDerWijden @lightclient
core: set withdrawals hash in genesis, fix tests, add withdrawalRoot
e8c8df4
@MariusVanDerWijden
all: implement forkid changes for shanghai
19b4bc8
@MariusVanDerWijden
Merge pull request #14 from MariusVanDerWijden/forkid-shanghai
c849633 
all: implement forkid changes for shanghai
@MariusVanDerWijden
core/types: make fetchers fetch withdrawals without transactions
dae68e2
@lightclient
Merge pull request #16 from MariusVanDerWijden/withdrawal-sync
38938d0 
core/types: make fetchers fetch withdrawals without transactions
@MariusVanDerWijden
internal/ethapi: add withdrawals to full block
b503634
@MariusVanDerWijden
internal/ethapi: add comment
a47d174
@MariusVanDerWijden
Merge pull request #17 from MariusVanDerWijden/marshal-withdrawals
955c423 
internal/ethapi: add withdrawals to full block
@MariusVanDerWijden
core/forkid: fix forkid filter
929035e
@MariusVanDerWijden
params: use shanghai time instead of block
8d6f965
@MariusVanDerWijden
miner: catalyst: return transaction fees for block
6d7e0b7
@lightclient
Merge pull request #20 from MariusVanDerWijden/shanghai-time
0686d05 
params: use shanghai time instead of block
@lightclient
Merge pull request #21 from MariusVanDerWijden/payload-fees
4ae8550 
miner: catalyst: return transaction fees for block
@mkalinin
Copy link

Notice on the proposed change that if accepted will affect this PR ethereum/execution-apis#337

@MariusVanDerWijden MariusVanDerWijden force-pushed the withdrawals-timestamp branch 3 times, most recently from 0503779 to 9e5053b Compare January 18, 2023 11:33
@MariusVanDerWijden
Copy link
Collaborator Author

stale, closing

lightclient pushed a commit that referenced this pull request Oct 5, 2023
@jmcook1186
Merge pull request #23 from ethereum/jc-tracing
ba7afcb 
move tracing docs into new dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MariusVanDerWijden @mkalinin @lightclient