Implement EIP-2937 #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an indestructable property to a contract instance
-added new EVM error for when an indestructible contract tries to self destruct -added if case in opsuicide to throw the error described above when an indestructible contract tries to opSuicide -appeased some golint stuff
* added 2937 to valideip map * added comments to exported functions to appease go linter * updated bastanchury instructionset to inherit yolov2 * set opcode to 0xa8 per eip spec
reverted change made that was unrelated to PR/EIP
lightclient
force-pushed
the
impl-eip-2718
branch
2 times, most recently
from
2f696dc
to
254a593
Compare
added 4 commits
January 10, 2021 10:11
holiman
reviewed
Jan 23, 2021
| @@ -270,7 +270,7 @@ func (evm *EVM) Call(caller ContractRef, addr common.Address, input []byte, gas | |||
| // The depth-check is already done, and precompiles handled above | |||
| contract := NewContract(caller, AccountRef(addrCopy), value, gas) | |||
| contract.SetCallCode(&addrCopy, evm.StateDB.GetCodeHash(addrCopy), code) | |||
| ret, err = run(evm, contract, input, false) | |||
| ret, err = run(evm, contract, input, false, false) | |||
There was a problem hiding this comment.
I think this highlights the commens I made on FEM about the EIP: it's far too vaguely specified. In this case, it appears that executing this sequence:
- A calls
B. Bdoesset-indesructibleas the first op.Bcalls onCCdoes selfdestruct, but is prevented, because the flag was stickified fromB.
This implementation seems based on the static mode, which is meant to be 'sticky' -- following along any child scopes.
I don't interpret the EIP to have the same semantics, though
holiman
force-pushed
the
impl-eip-2718
branch
4 times, most recently
from
3c8c36c
to
77fea7f
Compare
holiman
force-pushed
the
impl-eip-2718
branch
from
d56dd5a
to
e571bfe
Compare
holiman
force-pushed
the
impl-eip-2718
branch
2 times, most recently
from
525ab04
to
d1be5fa
Compare
lightclient
pushed a commit
that referenced
this pull request
Jun 16, 2021
…er (#7) (ethereum#22989) Co-authored-by: Gary Rong <garyrong0905@gmail.com> Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Set Indestructible Opcode