Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inhibitor to queue before activation #12

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Add inhibitor to queue before activation #12

merged 3 commits into from
Apr 22, 2024

Conversation

lightclient
Copy link
Owner

This PR implements a features first requested by @marioevz.

The concern is that before 7002 becomes active, it would be possible to join the queue without excess growing. This means the queue could be filled extremely cheaply.

To avoid this, we set the value of excess to an extremely high value so that no user could ever pay a fee to enter the queue. This avoids additional sloads during normal operations.

We chose 1181 as the value of excess because i) it a prime and ii) fake_exponential(1, 1181, 17) = 1481455745989958413761130954915 wei which is more than 1 trillion eth. That's more eth than will (hopefully) ever exist.

Each system call will check excess == 1181 and use 0 in it's place if so. This of course will only be true for the first call following activation of Prague.

@lightclient lightclient merged commit e0d68e0 into main Apr 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant