Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames exits to withdraw requests all over the code #8

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

mkalinin
Copy link
Contributor

@mkalinin mkalinin commented Apr 4, 2024

Depends on #7, decided to put this change aside as renaming is quite big in terms of the diff.

EIP-7002 is extended to support not only full exits but also partial withdrawals, thus, exit should be replaced with a more general term. Withdraw requests is the term used by the EIP-7251 CL spec.

@ralexstokes
Copy link

given that we are multiplexing multiple operations on top of the one EL message, it may be better to use an even more general term like OperationRequest

esp if we end up with 7251 EL-init'd consolidation messages, this may end up a bit overloaded so a more general name is better

@mkalinin
Copy link
Contributor Author

mkalinin commented Apr 5, 2024

given that we are multiplexing multiple operations on top of the one EL message, it may be better to use an even more general term like OperationRequest

esp if we end up with 7251 EL-init'd consolidation messages, this may end up a bit overloaded so a more general name is better

I don’t think we will have any other EL activated operation as a part of 7002. If we end up introducing EL triggered consolidations or anything else after 7002 this will rather be another EIP with its own terms and data structs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants