lightingbeetle · adammockor · Jan 5, 2020 · Oct 23, 2018 · Nov 17, 2018 · Sep 8, 2019
diff --git a/.alexignore b/.alexignore
@@ -0,0 +1,4 @@
+build
+
+CHANGELOG*
+CODE_OF_CONDUCT.md
diff --git a/.alexrc b/.alexrc
@@ -0,0 +1,18 @@
+{
+  "allow": [
+    "attacks",
+    "colors",
+    "conservative",
+    "crashes",
+    "executed",
+    "executes",
+    "execution",
+    "failed",
+    "hook",
+    "host-hostess",
+    "hostesses-hosts",
+    "invalid",
+    "remain",
+    "watchman-watchwoman"
+  ]
+}
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -1,2 +1,2 @@
-packages/ @bugzpodder @ianschmitz @iansu @mrmckeb @petetnt
+packages/ @ianschmitz @iansu @mrmckeb @petetnt
 docusaurus/ @amyrlam @iansu
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -0,0 +1,13 @@
+name: Build
+
+on: [push]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v1
+      - name: Install
+        run: yarn --no-progress --non-interactive --no-lockfile
+      - name: Build
+        run: yarn build
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -0,0 +1,13 @@
+name: Lint
+
+on: [push]
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v1
+      - name: Install
+        run: yarn --no-progress --non-interactive --no-lockfile
+      - name: Alex
+        run: yarn alex
diff --git a/.gitignore b/.gitignore
@@ -12,3 +12,4 @@ yarn-debug.log*
 yarn-error.log*
 /.changelog
 .npm/
+yarn.lock
diff --git a/CHANGELOG-1.x.md b/CHANGELOG-1.x.md
@@ -1577,20 +1577,20 @@ Unhandled Promise rejections will now crash tests. You can fix them by explicitl
 After the regular update procedure above, add these line to `<head>` in `public/index.html`:
 
 ```html
-    <meta name="theme-color" content="#000000">
-    <!--
+<meta name="theme-color" content="#000000" />
+<!--
       manifest.json provides metadata used when your web app is added to the
       homescreen on Android. See https://developers.google.com/web/fundamentals/engage-and-retain/web-app-manifest/
     -->
-    <link rel="manifest" href="%PUBLIC_URL%/manifest.json">
+<link rel="manifest" href="%PUBLIC_URL%/manifest.json" />
 ```
 
 Add `<noscript>` to `<body>` in `public/index.html`:
 
 ```html
-    <noscript>
-      You need to enable JavaScript to run this app.
-    </noscript>
+<noscript>
+  You need to enable JavaScript to run this app.
+</noscript>
 ```
 
 Then create a file called `public/manifest.json` that looks like this:

diff --git a/azure-pipelines-test-job.yml b/azure-pipelines-test-job.yml
@@ -6,35 +6,35 @@ parameters:
   name: ''
   testScript: ''
   configurations:
-    LinuxNode8:    { vmImage: 'ubuntu-16.04',   nodeVersion: 8.x  }
-    LinuxNode10:   { vmImage: 'ubuntu-16.04',   nodeVersion: 10.x }
-    WindowsNode8:  { vmImage: 'vs2017-win2016', nodeVersion: 8.x  }
-    WindowsNode10: { vmImage: 'vs2017-win2016', nodeVersion: 10.x }
-    
+    LinuxNode8: { vmImage: 'ubuntu-16.04', nodeVersion: 8.x }
+    LinuxNode10: { vmImage: 'ubuntu-16.04', nodeVersion: 10.x }
+    # WindowsNode8:  { vmImage: 'vs2017-win2016', nodeVersion: 8.x  }
+    # WindowsNode10: { vmImage: 'vs2017-win2016', nodeVersion: 10.x }
+
 jobs:
-- job: ${{ parameters.name }}
-  strategy:
-    matrix:
-      ${{ insert }}: ${{ parameters.configurations }}
-  pool:
-    vmImage: $(vmImage)
-  steps:
-  - script: |
-      git config --global core.autocrlf false
-      git config --global user.name "Create React App"
-      git config --global user.email "cra@email.com"
-    displayName: 'Initialize Git config'
+  - job: ${{ parameters.name }}
+    strategy:
+      matrix:
+        ${{ insert }}: ${{ parameters.configurations }}
+    pool:
+      vmImage: $(vmImage)
+    steps:
+      - script: |
+          git config --global core.autocrlf false
+          git config --global user.name "Create React App"
+          git config --global user.email "cra@email.com"
+        displayName: 'Initialize Git config'
 
-  - checkout: self
-    path: create-react-app
+      - checkout: self
+        path: create-react-app
 
-  - task: NodeTool@0
-    inputs:
-      versionSpec: $(nodeVersion)
-    displayName: 'Install Node.js'
+      - task: NodeTool@0
+        inputs:
+          versionSpec: $(nodeVersion)
+        displayName: 'Install Node.js'
 
-  - script: yarn --frozen-lockfile
-    displayName: 'Run yarn'
+      - script: yarn --frozen-lockfile
+        displayName: 'Run yarn'
 
-  - bash: ${{ parameters.testScript }}
-    displayName: 'Run tests'
+      - bash: ${{ parameters.testScript }}
+        displayName: 'Run tests'
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -3,7 +3,7 @@
 #
 
 trigger:
-- master
+  - master
 
 variables:
   CI: true
@@ -14,65 +14,79 @@ variables:
   VSTS_OVERWRITE_TEMP: True
   # Override Verdaccio package to use. This is temporary and is needed to avoid socket timeouts on hosted Windows agent (on Azure). This also changes Verdaccio to return a 503 (service unavailable) instead of a 404 (not found) when the connection to the uplink timesout.
   VERDACCIO_PACKAGE: https://github.com/willsmythe/verdaccio/releases/download/create-react-app/verdaccio-4.0.0-alpha.8.tgz
+  CRA_INTERNAL_TEST: true
 
 # ******************************************************************************
 # Simple test suite
 # ******************************************************************************
 jobs:
-- template: azure-pipelines-test-job.yml
-  parameters:
-    name: Simple
-    testScript: tasks/e2e-simple.sh
+  - template: azure-pipelines-test-job.yml
+    parameters:
+      name: Simple
+      testScript: tasks/e2e-simple.sh
 
-# ******************************************************************************
-# Installs test suite
-# ******************************************************************************
-- template: azure-pipelines-test-job.yml
-  parameters:
-    name: Installs
-    testScript: tasks/e2e-installs.sh
+  # ******************************************************************************
+  # Installs test suite
+  # ******************************************************************************
+  - template: azure-pipelines-test-job.yml
+    parameters:
+      name: Installs
+      testScript: tasks/e2e-installs.sh
 
-# ******************************************************************************
-# Kitchensink test suite
-# ******************************************************************************
-- template: azure-pipelines-test-job.yml
-  parameters:
-    name: Kitchensink
-    testScript: tasks/e2e-kitchensink.sh
+  # ******************************************************************************
+  # Kitchensink test suite
+  # ******************************************************************************
+  - template: azure-pipelines-test-job.yml
+    parameters:
+      name: Kitchensink
+      testScript: tasks/e2e-kitchensink.sh
 
-# ******************************************************************************
-# Kitchensink Eject test suite
-# ******************************************************************************
-- template: azure-pipelines-test-job.yml
-  parameters:
-    name: KitchensinkEject
-    testScript: tasks/e2e-kitchensink-eject.sh
+  # ******************************************************************************
+  # Kitchensink Eject test suite
+  # ******************************************************************************
+  - template: azure-pipelines-test-job.yml
+    parameters:
+      name: KitchensinkEject
+      testScript: tasks/e2e-kitchensink-eject.sh
 
-# ******************************************************************************
-# Behavior test suite
-# ******************************************************************************
-- template: azure-pipelines-test-job.yml
-  parameters:
-    name: Behavior
-    testScript: tasks/e2e-behavior.sh
-    configurations:
-      LinuxNode8:    { vmImage: 'ubuntu-16.04',   nodeVersion: 8.x  }
-      LinuxNode10:   { vmImage: 'ubuntu-16.04',   nodeVersion: 10.x }
-      WindowsNode8:  { vmImage: 'vs2017-win2016', nodeVersion: 8.x  }
-      WindowsNode10: { vmImage: 'vs2017-win2016', nodeVersion: 10.x }
-      MacNode8:      { vmImage: 'macOS-10.13',    nodeVersion: 8.x  }
-      MacNode10:     { vmImage: 'macOS-10.13',    nodeVersion: 10.x }
+  # ******************************************************************************
+  # Behavior test suite
+  # ******************************************************************************
+  - template: azure-pipelines-test-job.yml
+    parameters:
+      name: Behavior
+      testScript: tasks/e2e-behavior.sh
+      configurations:
+        LinuxNode8: { vmImage: 'ubuntu-16.04', nodeVersion: 8.x }
+        LinuxNode10: { vmImage: 'ubuntu-16.04', nodeVersion: 10.x }
+        # WindowsNode8:  { vmImage: 'vs2017-win2016', nodeVersion: 8.x  }
+        # WindowsNode10: { vmImage: 'vs2017-win2016', nodeVersion: 10.x }
+        MacNode8: { vmImage: 'macOS-10.13', nodeVersion: 8.x }
+        MacNode10: { vmImage: 'macOS-10.13', nodeVersion: 10.x }
 
-# ******************************************************************************
-# Old Node test suite
-# ******************************************************************************
-- job: OldNode
-  pool:
-    vmImage: ubuntu-16.04
-  steps:
-    - task: NodeTool@0
-      inputs:
-        versionSpec: 6.x
-      displayName: 'Install Node.js 6.x'
-    - bash: tasks/e2e-old-node.sh
-      displayName: 'Run tests'
+  # ******************************************************************************
+  # Old Node test suite
+  # ******************************************************************************
+  - job: OldNode
+    pool:
+      vmImage: ubuntu-16.04
+    steps:
+      - task: NodeTool@0
+        inputs:
+          versionSpec: 6.x
+        displayName: 'Install Node.js 6.x'
+      - bash: tasks/e2e-old-node.sh
+        displayName: 'Run tests'
+  # ******************************************************************************
+  # Unsupported Node with TypeScript flag
+  # ******************************************************************************
+  - job: UnsupportedNodeWithTypeScript
+    pool:
+      vmImage: ubuntu-16.04
+    steps:
+      - task: NodeTool@0
+        inputs:
+          versionSpec: 8.9.x
+        displayName: 'Install Node.js 8.9.x'
+      - bash: tasks/e2e-typescript-unsupported-node.sh
+        displayName: 'Run unsupported TypeScript test'
diff --git a/docusaurus/docs/adding-bootstrap.md b/docusaurus/docs/adding-bootstrap.md
@@ -29,7 +29,8 @@ import 'bootstrap/dist/css/bootstrap.css';
 
 > Note: this feature is available with `react-scripts@2.0.0` and higher.
 
-Sometimes you might need to tweak the visual styles of Bootstrap (or equivalent package).<br>
+Sometimes you might need to tweak the visual styles of Bootstrap (or equivalent package).
+
 As of `react-scripts@2.0.0` you can import `.scss` files. This makes it possible to use a package's built-in Sass variables for global style preferences.
 
 To enable `scss` in Create React App you will need to install `node-sass`.
@@ -38,7 +39,7 @@ To enable `scss` in Create React App you will need to install `node-sass`.
 npm install --save node-sass
 ```
 
-Alternatively you may use `yarn`::
+Alternatively you may use `yarn`:
 
 ```sh
 yarn add node-sass

diff --git a/docusaurus/docs/adding-custom-environment-variables.md b/docusaurus/docs/adding-custom-environment-variables.md
@@ -12,13 +12,13 @@ Your project can consume variables declared in your environment as if they were
 >
 > Environment variables are embedded into the build, meaning anyone can view them by inspecting your app's files.
 
-**The environment variables are embedded during the build time**. Since Create React App produces a static HTML/CSS/JS bundle, it can’t possibly read them at runtime. To read them at runtime, you would need to load HTML into memory on the server and replace placeholders in runtime, just like [described here](title-and-meta-tags.md#injecting-data-from-the-server-into-the-page). Alternatively you can rebuild the app on the server anytime you change them.
+**The environment variables are embedded during the build time**. Since Create React App produces a static HTML/CSS/JS bundle, it can’t possibly read them at runtime. To read them at runtime, you would need to load HTML into memory on the server and replace placeholders in runtime, as [described here](title-and-meta-tags.md#injecting-data-from-the-server-into-the-page). Alternatively you can rebuild the app on the server anytime you change them.
 
 > Note: You must create custom environment variables beginning with `REACT_APP_`. Any other variables except `NODE_ENV` will be ignored to avoid accidentally [exposing a private key on the machine that could have the same name](https://github.com/facebook/create-react-app/issues/865#issuecomment-252199527). Changing any environment variables will require you to restart the development server if it is running.
 
 These environment variables will be defined for you on `process.env`. For example, having an environment variable named `REACT_APP_NOT_SECRET_CODE` will be exposed in your JS as `process.env.REACT_APP_NOT_SECRET_CODE`.
 
-There is also a special built-in environment variable called `NODE_ENV`. You can read it from `process.env.NODE_ENV`. When you run `npm start`, it is always equal to `'development'`, when you run `npm test` it is always equal to `'test'`, and when you run `npm run build` to make a production bundle, it is always equal to `'production'`. **You cannot override `NODE_ENV` manually.** This prevents developers from accidentally deploying a slow development build to production.
+There is also a built-in environment variable called `NODE_ENV`. You can read it from `process.env.NODE_ENV`. When you run `npm start`, it is always equal to `'development'`, when you run `npm test` it is always equal to `'test'`, and when you run `npm run build` to make a production bundle, it is always equal to `'production'`. **You cannot override `NODE_ENV` manually.** This prevents developers from accidentally deploying a slow development build to production.
 
 These environment variables can be useful for displaying information conditionally based on where the project is deployed or consuming sensitive data that lives outside of version control.
 
@@ -136,7 +136,8 @@ Files on the left have more priority than files on the right:
 - `npm run build`: `.env.production.local`, `.env.production`, `.env.local`, `.env`
 - `npm test`: `.env.test.local`, `.env.test`, `.env` (note `.env.local` is missing)
 
-These variables will act as the defaults if the machine does not explicitly set them.<br>
+These variables will act as the defaults if the machine does not explicitly set them.
+
 Please refer to the [dotenv documentation](https://github.com/motdotla/dotenv) for more details.
 
 > Note: If you are defining environment variables for development, your CI and/or hosting platform will most likely need

diff --git a/docusaurus/docs/adding-flow.md b/docusaurus/docs/adding-flow.md
@@ -22,7 +22,7 @@ make sure to add the following line to your `.flowconfig` to make Flow aware of
 
 ```diff
   [options]
-+ module.name_mapper='^\(.*\)$' -> '<PROJECT_ROOT>/src/\1'
++ module.name_mapper='^\([^\.].*\)$' -> '<PROJECT_ROOT>/src/\1'
 ```
 
 To learn more about Flow, check out [its documentation](https://flow.org/).
diff --git a/docusaurus/docs/adding-images-fonts-and-files.md b/docusaurus/docs/adding-images-fonts-and-files.md
@@ -35,11 +35,12 @@ This works in CSS too:
 }
 ```
 
-Webpack finds all relative module references in CSS (they start with `./`) and replaces them with the final paths from the compiled bundle. If you make a typo or accidentally delete an important file, you will see a compilation error, just like when you import a non-existent JavaScript module. The final filenames in the compiled bundle are generated by Webpack from content hashes. If the file content changes in the future, Webpack will give it a different name in production so you don’t need to worry about long-term caching of assets.
+Webpack finds all relative module references in CSS (they start with `./`) and replaces them with the final paths from the compiled bundle. If you make a typo or accidentally delete an important file, you will see a compilation error, like when you import a non-existent JavaScript module. The final filenames in the compiled bundle are generated by Webpack from content hashes. If the file content changes in the future, Webpack will give it a different name in production so you don’t need to worry about long-term caching of assets.
 
 Please be advised that this is also a custom feature of Webpack.
 
-**It is not required for React** but many people enjoy it (and React Native uses a similar mechanism for images).<br>
+**It is not required for React** but many people enjoy it (and React Native uses a similar mechanism for images).
+
 An alternative way of handling static assets is described in the next section.
 
 ## Adding SVGs
@@ -58,6 +59,6 @@ const App = () => (
 );
 ```
 
-This is handy if you don't want to load SVG as a separate file. Don't forget the curly braces in the import! The `ReactComponent` import name is special and tells Create React App that you want a React component that renders an SVG, rather than its filename.
+This is handy if you don't want to load SVG as a separate file. Don't forget the curly braces in the import! The `ReactComponent` import name is significant and tells Create React App that you want a React component that renders an SVG, rather than its filename.
 
-> **Tip:** The imported SVG React Component accepts a `title` prop along with other props that a `svg` element accepts. Use this prop to add an accessbile title to your svg component.
+> **Tip:** The imported SVG React Component accepts a `title` prop along with other props that a `svg` element accepts. Use this prop to add an accessible title to your svg component.
diff --git a/docusaurus/docs/adding-relay.md b/docusaurus/docs/adding-relay.md
@@ -3,7 +3,7 @@ id: adding-relay
 title: Adding Relay
 ---
 
-Relay is a framework for building data-driven React applications powered by GraphQL. The current release of Relay works with Create React App projects out of the box using Babel Macros. Simply set up your project as laid out in the [Relay documentation](https://facebook.github.io/relay/), then make sure you have a version of the babel plugin providing the macro.
+Relay is a framework for building data-driven React applications powered by GraphQL. The current release of Relay works with Create React App projects out of the box using Babel Macros. Set up your project as shown in the [Relay documentation](https://facebook.github.io/relay/), then make sure you have a version of the babel plugin providing the macro.
 
 To add it, run: