Adding type check for serve.py #1652
Conversation
|
Hey @philippmwirth, please review this MR. Thanks. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1652 +/- ##
=======================================
Coverage 84.70% 84.70%
=======================================
Files 151 151
Lines 6446 6446
=======================================
Hits 5460 5460
Misses 986 986 ☔ View full report in Codecov by Sentry. |
|
Partly fixes #1635 |
|
Hey, thanks, very new to this open source, can you also merge it ? or do you guys follow some release timelines ? |
Hello 👋🏽 , I think in order for this PR to count for your Hacktoberfest total we'd have to merge it between Oct 1-31. I'm going to wait on @guarin for this. |
|
Ohh, but I am not doing it for hacktober fest, so if you can merge it then please go ahead, Thanks. |
| @@ -42,7 +42,7 @@ def do_OPTIONS(self) -> None: | |||
| self.send_header("Access-Control-Allow-Methods", "GET, POST, OPTIONS") | |||
| self.end_headers() | |||
|
|
|||
| def send_response_only(self, code, message=None): | |||
| def send_response_only(self, code: int, message: str | None = None) -> None: | |||
There was a problem hiding this comment.
Could you change this to use Optional (can be imported with from typing import Optional)?
| def send_response_only(self, code: int, message: str | None = None) -> None: | |
| def send_response_only(self, code: int, message: Optional[str] = None) -> None: |
The package is still used on some older Python versions (<3.10) which do not yet support the new X | Y typing syntax introduced in 3.10. This is usually caught by our tests but this specific function is not tested :(
Edit: Actually, let's just add from __future__ import annotations at the top of the file. Then Python 3.10 types are also supported on older versions.
There was a problem hiding this comment.
okay, will add and crate a PR
There was a problem hiding this comment.
No need to create a new PR, you can just update this one.
No description provided.