Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rainfallalmanac.php hard coded date #41

Open
steepleian opened this issue May 23, 2019 · 0 comments
Open

rainfallalmanac.php hard coded date #41

steepleian opened this issue May 23, 2019 · 0 comments
Assignees
@lightmaster
Labels
bug Something isn't working

Comments

@steepleian
Copy link
Contributor

On line 161 of the rainfallalmanac.php there is a hard coded date : -

'Since Jan 2018'

I think this should be set as a variable == the date stamp of the first record in the database
@steepleian steepleian added the bug Something isn't working label May 23, 2019
lightmaster added a commit that referenced this issue Jun 1, 2019
@lightmaster
Tweaking almanac css
55c2ee8 
Fixed up some alignment and spacing issues on all almanacs (Issue #42)
Partially fixed hardcoded dates in rain almanac (Issue #41)
lightmaster added a commit that referenced this issue Jun 8, 2019
@lightmaster
Tweaking the Almanacs...
40f4b48 
**REQUIRES MB REBOOT WHEN API IS UPDATED**

For MB Pro and Nano SD, will now calculate when the 'rain all time' total started. Unforuately, this value isn't reported by the other MBs, at least according to the documention.
Centers the headers of the almanacs
Makes the barometric almanac min and max text colored like the boxes next to them.
Changes most Month names to be the abreviated name to save space on pages.
Fixes another bit of hardcoded dates from Issue #41.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lightmaster lightmaster

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lightmaster @steepleian