fix: safari 9 HTMLImageElement check #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsassph
reviewed
Dec 12, 2024
| ((typeof obj === 'object' && | ||
| obj.constructor && | ||
| obj.constructor.name === 'HTMLImageElement') || | ||
| obj instanceof HTMLImageElement) |
There was a problem hiding this comment.
would it be safe/better to do the instanceof check first?
wouterlucas
reviewed
Dec 12, 2024
| ((typeof obj === 'object' && | ||
| obj.constructor && | ||
| obj.constructor.name === 'HTMLImageElement') || | ||
| (typeof HTMLImageElement !== 'undefined' && |
There was a problem hiding this comment.
Hopefully this works if we're rendering in a webworker again - though granted if we're doing offscreen rendering the chances are that we're using Canvas rendering are quite low.
That plus ThreadX being months out from a useable state again, its fine.
wouterlucas
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.