This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
fix(Storybook): fixes white flash #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arwehrman
commented
Nov 17, 2023
| @@ -44,10 +44,7 @@ const preview = { | |||
| backgrounds: { default: 'dark' }, | |||
| actions: { argTypesRegex: '^on[A-Z].*' }, | |||
| controls: { | |||
| matchers: { | |||
There was a problem hiding this comment.
don't actually need to put this in here, it the default config
arwehrman
commented
Nov 17, 2023
| color: /(background|color)$/i, | ||
| date: /Date$/ | ||
| } | ||
| expanded: true |
There was a problem hiding this comment.
adds description and default column to the controls table
arwehrman
force-pushed
the
fix/storybook-controls-config
branch
from
701adbf to
5757943
Compare
|
linked wrong branch and changes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to 6.5, we were able to set
appBGin the custom Storybook Theme to set the background in the Preview iframe. This is no longer the case. There are possible fixes coming but have not seen them actually committed to a release yet. See this prThe other known issue is a white flash when clicking from a Story to the Docs of that Story. This is related to some classes being displayed and not displayed during 'loading' of the pages. The CSS overrides added in this PR are to fix those issues until Storybook fixes them.
This PR makes a few updates to the Storybook configuration:
appBGand the loading issue styles when clicking between Stories and Docs