Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include BIP 353 name info in invoice_requests #1180

Merged
merged 1 commit into from
Dec 2, 2024
+13 −0
Merged

Include BIP 353 name info in invoice_requests #1180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions 12-offer-encoding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,12 @@ while still allowing signature validation.
1. type: 90 (`invreq_paths`)
2. data:
* [`...*blinded_path`:`paths`]
1. type: 91 (`invreq_bip_353_name`)
2. data:
* [`u8`:`name_len`]
* [`name_len*byte`:`name`]
* [`u8`:`domain_len`]
* [`domain_len*byte`:`domain`]
1. type: 240 (`signature`)
2. data:
* [`bip340sig`:`sig`]
Expand Down Expand Up @@ -481,6 +487,10 @@ The writer:
(e.g. milli-satoshis for bitcoin) for `invreq_chain` (or for bitcoin, if there is no `invreq_chain`).
- if it supports bolt12 invoice request features:
- MUST set `invreq_features`.`features` to the bitmap of features.
- if it received the offer from which it constructed this `invoice_request` using BIP 353 resolution:
- MUST include `invreq_bip_353_name` with,
- `name` set to the post-₿, pre-@ part of the BIP 353 HRN,
- `domain` set to the post-@ part of the BIP 353 HRN.

The reader:
- MUST reject the invoice request if `invreq_payer_id` or `invreq_metadata` are not present.
Expand Down Expand Up @@ -528,6 +538,9 @@ The reader:
- MUST use `invreq_paths` if present, otherwise MUST use `invreq_payer_id` as the node id to send to.
- if `invreq_chain` is not present:
- MUST reject the invoice request if bitcoin is not a supported chain.
- if `invreq_bip_353_name` is present:
- MUST reject the invoice request if `name` or `domain` contain any bytes which are not
`0`-`9`, `a`-`z`, `A`-`Z`, `-`, `_` or `.`.
- otherwise:
- MUST reject the invoice request if `invreq_chain`.`chain` is not a supported chain.

Expand Down