BOLT 8: add missing MAC check in Act Three #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
in the beginning of the text the spec gives a general statement:
Thus this seems very logical to me. |
|
Feels to me as well that terminating the connection is the sane choice here. |
t-bast
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presumably, this
decryptWithADalso has a MAC check that can potentially fail, like the other ones. Unlike the other ones, this one does not describe what MUST happen if the MAC check fails.Maybe it's just a nitpick. Terminating the connection without any further messages seems sensible to me in this case, but I'm not 100% sure if it's necessary, or even if it could be harmful. So don't take my word for it that this is the right behavior: think about it.