Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed requirement to broadcast an outdated commitment transaction #942

Merged
merged 2 commits into from
Jan 17, 2022

Commits on Dec 5, 2021

  1. Removed requirement to broadcast an outdated commitment transaction

    If a node has to fail a channel but knows that its latest commitment transaction is outdated it should not be required to send it but rather wait for the peer to unilaterally close the channel. 
    
    The proposed solution is not so clean because it might produce a deadlock in which two peers assume they have outdated state and send `error` back and forth without actually force closing. Maybe in such a scenario we could create a protocol that mutually closes with split balance? 
    
    Also replaced the word use with broadcast as it seems more accurate.
    lightning-developer authored Dec 5, 2021
    Configuration menu
    Copy the full SHA
    fdd791a View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. Add changes from lightning#932

    It was decided in the spec meeting to combine lightning#932 and lightning#942 as they are
    closely related. It was also decided to add a rationale for lightning#932 to clearly
    state why nodes must wait for an error before force-closing instead of
    eagerly force-closing when detecting that their peer is behind.
    t-bast authored and lightning-developer committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    b60e2b2 View commit details
    Browse the repository at this point in the history