BOLT 2: disallow sending multiple shutdown msg
#977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
changed the title
shutdown msgshutdown msg
vincenzopalazzo
force-pushed
the
macros/disallow_multiple_shutdown
branch
from
1809526
to
acb4646
Compare
23 tasks
vincenzopalazzo
force-pushed
the
macros/disallow_multiple_shutdown
branch
from
acb4646
to
648dc5e
Compare
t-bast
approved these changes
May 9, 2022
TheBlueMatt
reviewed
May 9, 2022
Roasbeef
reviewed
May 9, 2022
vincenzopalazzo
force-pushed
the
macros/disallow_multiple_shutdown
branch
from
648dc5e
to
73bbb56
Compare
This is a second proposal different from lightning#976 where it is not allowed to send multiple shutdown messages from the receiver viewpoint. The rationale for this is to avoid bad cases like the following one that is permitted by the spec ``` ____________________________________________ | sender -> shutdown(script_one) -> receiver | | sender -> shutdown(script_two) -> receiver | | sender <- shutdown(script_one) <- receiver | -------------------------------------------- ``` Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
force-pushed
the
macros/disallow_multiple_shutdown
branch
from
73bbb56
to
3afa56e
Compare
|
Trivial rebase and fixed the changes discussed in the last meeting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second proposal different from #976 where it is not allowed to send multiple shutdown messages from the receiver viewpoint.
The rationale for this is to avoid bad cases like the following one that is permitted by the spec