Commits on Apr 21, 2022

1. Remove zlib compression gossip query support …

   Gossip query compression is not very useful - it was added for
   mobile clients to, in theory, sync the gossip data directly from
   P2P peers, but to my knowledge no mobile clients actually use it
   for that, or at least use it where the gossip *query* data is a
   substantial portion of their overall bandwidth usage.
   
   Further, because of the semantics of `gossip_timestamp_filter`, its
   impractical to ensure you receive a reliable, full view of the
   gossip data without re-downloading large portions of the gossip
   data on startup.
   
   Ultimately, gossip queries are a pretty non-optimal method of
   synchronizing the gossip data. If someone wants highly optimized
   gossip data synchronization a new method based on set
   reconciliation needs to be propose.
   
   Finally, the current gossip query encoding semantics do not allow
   for negotiation and instead require all lightning implementations
   take a zlib dependency in some form or another. Given the recent
   zlib decoding memory corruption vulnerability, this seems like an
   opportune time to simply remove the zlib support, requiring that
   nodes stop sending compressed gossip query data (though they can
   support reading such gossip query data as long as they wish).
   
   This is an alternative to the suggested gossip query encoding
   support in lightning#825.

   

   TheBlueMatt committed Apr 21, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 2e8f209
   • Browse repository at this point

   Copy the full SHA

   2e8f209 View commit details

   Browse the repository at this point in the history