-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
holdinvoice #482
holdinvoice #482
Conversation
Very nice 👍 Thanks for bearing with us @daywalker90, and sorry for the late move to the plugin repository ACK e56f197 |
Rebasing to get the CI running again. |
I tihnk the CI is broken: |
Yep, it seems that the CI has issues with python dependencies, will dig more tomorrow. Still familiarizing myself with this system... |
@cdecker looks like DEVELOPER is gone, should we just remove it? Or replace it with DEBUGBUILD? Or we can just keep it as is, it seems to set DEBUGBUILD now: https://github.com/ElementsProject/lightning/blob/master/configure#L252 |
Also looks like we can remove testing on python 3.7 and add a few more recent versions, since pyln-client doesn't support 3.7 anymore I'll put up a separate PR for a fix |
The |
@daywalker90 I think this PR is next up, right? If so, please rebase on master and let's see if the tests pass |
Actually let's try this @Mergifyio rebase |
@Mergifyio rebase |
☑️ Nothing to do
|
Hmm yeah looks like this needs a manual rebase @daywalker90 |
7ebe071
to
80a4909
Compare
|
@daywalker90 SGTM |
1ede5dc
to
60ea8b9
Compare
60ea8b9
to
913f2cd
Compare
79199f0
to
496de86
Compare
496de86
to
5e7988b
Compare
rebased and fixed tests for master |
ACK 5e7988b Looks great! Thanks for building this!! 🎉 |
Adds a plugin to hold invoices aka hodlinvoices. For more info see https://github.com/daywalker90/holdinvoice#documentation