Drop KVStore type parameter from Node
#244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2024-02-switch-to-dyn-kvstore
branch
3 times, most recently
from
3ed2d02
to
53f22d9
Compare
tnull
changed the title
KVStore generic from NodeKVStore type parameter from Node
tnull
force-pushed
the
2024-02-switch-to-dyn-kvstore
branch
2 times, most recently
from
b80a1be
to
8d1b497
Compare
Merged
tnull
force-pushed
the
2024-02-switch-to-dyn-kvstore
branch
from
8d1b497
to
abd8d1d
Compare
tnull
force-pushed
the
2024-02-switch-to-dyn-kvstore
branch
from
abd8d1d
to
e9cad46
Compare
tnull
force-pushed
the
2024-02-switch-to-dyn-kvstore
branch
from
e9cad46
to
4f4904d
Compare
tnull
force-pushed
the
2024-02-switch-to-dyn-kvstore
branch
2 times, most recently
from
d9e9f2e
to
8508d6c
Compare
|
Rebased to resolve minor conflicts. |
tnull
force-pushed
the
2024-02-switch-to-dyn-kvstore
branch
from
8508d6c
to
618aab5
Compare
Merged
tnull
force-pushed
the
2024-02-switch-to-dyn-kvstore
branch
from
618aab5
to
42c3644
Compare
tnull
force-pushed
the
2024-02-switch-to-dyn-kvstore
branch
from
42c3644
to
24614de
Compare
tnull
force-pushed
the
2024-02-switch-to-dyn-kvstore
branch
from
24614de
to
d1a33ce
Compare
tnull
force-pushed
the
2024-02-switch-to-dyn-kvstore
branch
from
d1a33ce
to
8b1a4c2
Compare
.. switching to `dyn KVStore + Send + Sync`
... now that we don't have any generic to hide, we can just use the `Node` type directly.
.. now that we can.
tnull
force-pushed
the
2024-02-switch-to-dyn-kvstore
branch
from
8b1a4c2
to
c566fd5
Compare
|
Rebased on main after #243 landed. |
jkczyz
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #243, depends on lightningdevkit/rust-lightning#2883
Previously, LDK Node's main object has a generic trait bound on
KVStore, i.e.,Node<K: KVStore + Send + Sync + 'static>. However, this has always been a painful issue as our bindings generator UniFFI doesn't have generic support, so we were required to type-def and expose only a concrete type, i.e.,Node<SqliteStore>, in bindings. This will now become even more painful and borderline infeasible with the upcoming introduction of theVssStorealternative.Here we therefore finally drop the generic trait bound, allowing us expose a cleaner
Nodeobject everywhere.Draft as blocked on upstream for now.