#2964 Followups #3003
Merged
#2964 Followups #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The block count at which the monitor will become prunable was changed by an update while the PR was pending but not propagated to the docs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3003 +/- ##
==========================================
+ Coverage 89.08% 89.21% +0.12%
==========================================
Files 118 118
Lines 97400 98065 +665
Branches 97400 98065 +665
==========================================
+ Hits 86773 87487 +714
+ Misses 8383 8339 -44
+ Partials 2244 2239 -5 ☔ View full report in Codecov by Sentry. |
G8XSU
previously approved these changes
Apr 18, 2024
G8XSU
reviewed
Apr 18, 2024
| @@ -1897,6 +1897,9 @@ impl<Signer: WriteableEcdsaChannelSigner> ChannelMonitor<Signer> { | |||
| (None, true) => { | |||
| // Claimed all funds but `balances_empty_height` is None. It is set to the | |||
| // current block height. | |||
| log_debug!(logger, | |||
| "ChannelMonitor funded at {} is now fully resolved. It will become prunable in {} blocks", | |||
There was a problem hiding this comment.
Suggested change
| "ChannelMonitor funded at {} is now fully resolved. It will become prunable in {} blocks", | |
| "ChannelMonitor funded at {} is now fully resolved. It will be archived in {} blocks", |
since we are sticking with the archive terminology.
There was a problem hiding this comment.
Went with "archivable" because we don't automatically archive, the user still has to do something.
TheBlueMatt
force-pushed
the
2024-04-2964-followups
branch
from
5f45831
to
fd0c3e4
Compare
|
Squash-pushed the last commit |
jbesraa
approved these changes
Apr 22, 2024
G8XSU
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followups from #2964 (review)