trivial clippy warning fixes #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
reviewed
Oct 8, 2020
lightning/src/ln/msgs.rs
Outdated
| @@ -41,7 +41,7 @@ use util::ser::{Readable, Writeable, Writer, FixedLengthReader, HighZeroBytesDro | |||
| use ln::channelmanager::{PaymentPreimage, PaymentHash, PaymentSecret}; | |||
|
|
|||
| /// 21 million * 10^8 * 1000 | |||
| pub(crate) const MAX_VALUE_MSAT: u64 = 21_000_000_0000_0000_000; | |||
There was a problem hiding this comment.
This is very specifically written this way because the number is 21 million * 10^8, and thus grouping the 8 into 2*4 is more readable. Same with the other SATS numbers.
rloomba
force-pushed
the
rloomba/trivial-clippy-fixes
branch
from
490c211
to
c8e49aa
Compare
Codecov Report
@@ Coverage Diff @@
## main #740 +/- ##
==========================================
- Coverage 91.99% 91.95% -0.04%
==========================================
Files 37 37
Lines 20108 20108
==========================================
- Hits 18498 18490 -8
- Misses 1610 1618 +8
Continue to review full report at Codecov.
|
TheBlueMatt
approved these changes
Oct 9, 2020
naumenkogs
pushed a commit
to naumenkogs/rust-lightning
that referenced
this pull request
Oct 21, 2020
When we receive an inbound HTLC from a peer on an inbound channel, make sure the funder can still cover the additional on-chain cost of the HTLC while maintaining their channel reserve. When we're sending an outbound HTLC, make sure the funder can still cover the additional on-chain cost of the HTLC while maintaining their channel reserve. + implement fee spike buffer for channel initiators sending payments. Also add an additional spec-deviating fee spike buffer on the receiving side (but don't close the channel if this reserve is violated, just fail the HTLC). From lightning-rfc PR lightningdevkit#740. Co-authored-by: Matt Corallo <git@bluematt.me> Co-authored-by: Valentine Wallace <vwallace@protonmail.com>
tnull
pushed a commit
to tnull/rust-lightning
that referenced
this pull request
Dec 5, 2020
When we receive an inbound HTLC from a peer on an inbound channel, make sure the funder can still cover the additional on-chain cost of the HTLC while maintaining their channel reserve. When we're sending an outbound HTLC, make sure the funder can still cover the additional on-chain cost of the HTLC while maintaining their channel reserve. + implement fee spike buffer for channel initiators sending payments. Also add an additional spec-deviating fee spike buffer on the receiving side (but don't close the channel if this reserve is violated, just fail the HTLC). From lightning-rfc PR lightningdevkit#740. Co-authored-by: Matt Corallo <git@bluematt.me> Co-authored-by: Valentine Wallace <vwallace@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trvial changes to fix
twoone clippy warning :clippy::inconsistent_digit_groupingandclippy::write_with_newline warnings.