Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

challenger+config: fix bugs related to config parsing and AMP invoice handling #103

Merged
merged 2 commits into from
Jul 5, 2023
Merged

challenger+config: fix bugs related to config parsing and AMP invoice handling #103

merged 2 commits into from
Jul 5, 2023

Conversation

Roasbeef
Copy link
Member

@Roasbeef Roasbeef commented Jul 5, 2023

In this PR, we fix to disticnt bugs:

  1. AMP invoices dont' have a payment hash, so if you connect to a node that has one, then some belt-and-suspenders parsing will fail.
  2. For the yaml parser, since the public attribute differs from the name of the yaml field, we need to specify the yaml flag.
    • Without this fix, the new backend can't be specified in the config file, only the command line args.

@Roasbeef Roasbeef mentioned this pull request Jul 5, 2023
Merged
@Roasbeef
challenger: skip trying to load+parse AMP invoices
599eb2e 
AMP invoiecs don't have a payment hash, as it's based on payment addr
and set id.
@Roasbeef
config: fix config parsing for new dbbackend option
c1dea36 
For the yaml parser, since the public attribute differs from the name of
the yaml field, we need to specify the `yaml` flag.
@Roasbeef Roasbeef merged commit 87bb996 into lightninglabs:master Jul 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Roasbeef