-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slog: update to use structured logs for hashmail server #148
base: master
Are you sure you want to change the base?
Conversation
d65d259
to
550bede
Compare
And update logging set up accordingly.
This will make querying by stream IDs more uniform (and hence, way easier).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! And cool to see a demo of the context based trace functionality 💯
LGTM pending the dependent PRs and the err
value fix.
@@ -4,6 +4,7 @@ import ( | |||
"bytes" | |||
"context" | |||
"fmt" | |||
"github.com/btcsuite/btclog" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: need to make fmt
.
log.DebugS(ctxl, "New HashMail stream init", "auth", init.Auth) | ||
|
||
if err := h.ValidateStreamAuth(ctxl, init); err != nil { | ||
log.DebugS(ctxl, "Stream creation validation failed", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be "err", err
, otherwise this would show as "bad key", because DebugS
doesn't have an err
parameter. Same further below.
Update aperture's btclog and lnd deps so that it can take advantage of structure logging.
Then start using the structured logs for the hashmail server.
This will make querying logs much easier & faster.
Example
Main thing to note here is the uniformity of the "stream_id" attribute in the new logs.
Old:
New: