slog: update to use structured logs for hashmail server #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
force-pushed
the
slog
branch
3 times, most recently
from
550bede
to
50cbe19
Compare
guggero
approved these changes
Sep 16, 2024
hashmail_server.go
Outdated
| log.DebugS(ctxl, "New HashMail stream init", "auth", init.Auth) | ||
|
|
||
| if err := h.ValidateStreamAuth(ctxl, init); err != nil { | ||
| log.DebugS(ctxl, "Stream creation validation failed", err) |
There was a problem hiding this comment.
I think this needs to be "err", err, otherwise this would show as "bad key", because DebugS doesn't have an err parameter. Same further below.
There was a problem hiding this comment.
a yes good catch!
makes me wonder if we should switch this to a "WarnS"? but anyways, keeping it as debug for now 👍
ellemouton
force-pushed
the
slog
branch
2 times, most recently
from
c329b86
to
2a10761
Compare
Update the deps so that structured logging is availabel in aperture.
This will make querying by stream IDs more uniform (and hence, way easier).
guggero
approved these changes
Oct 28, 2024
| @@ -621,6 +629,9 @@ func (h *hashMailServer) SendStream(readStream hashmailrpc.HashMail_SendStreamSe | |||
| return err | |||
| } | |||
|
|
|||
| ctx := btclog.WithCtx(readStream.Context(), | |||
There was a problem hiding this comment.
nit: this is a normal (non-formatting) function call, so I think the other multi-line formatting rule would apply?
Same further below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update aperture's btclog and lnd deps so that it can take advantage of structure logging.
Then start using the structured logs for the hashmail server.
This will make querying logs much easier & faster.
Example
Main thing to note here is the uniformity of the "stream_id" attribute in the new logs.
Old:
New: