chore: adds github actions to push faraday docker images to docker hub #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How should this be tested?
To validate the effectiveness of the newly integrated GitHub Action for automating Docker image pushes to Docker Hub upon a new release, follow these steps:
Navigate to the repository's 'Releases' section.
Create a new release. You can do this by tagging a specific commit or using the repository's latest commit. Ensure that the release process mimics the standard release procedure for this repository.
2.Verify GitHub Action Execution:
Once the release is created, go to the 'Actions' tab in the GitHub repository.
You should see a new workflow run initiated by the release action. This workflow corresponds to the GitHub Action we have added for Docker image automation.
Click on the workflow run to view its details.
Review the logs to ensure that the GitHub Action executed correctly without any errors. Pay special attention to the steps where the Docker image is built and pushed to Docker Hub.
Go to the Docker Hub repository linked to this GitHub repository.
Verify that a new Docker image has been pushed successfully. Ensure the image tag matches the release version/tag created in step 1.
5.Optional: Pull and Run the Docker Image:
As an additional verification step, you can pull the newly pushed Docker image from Docker Hub to your local machine using docker pull <image_name>:.
Run the Docker image locally to ensure it's functioning as expected.
Please note that this GitHub Action is configured to trigger only on new releases. Any direct pushes or merged PRs to the main branch will not activate this action unless they are part of a release process.
Also note that the repo admin would need to create the docker hub and add the required environment variables
Pull Request Checklist
MinLndVersionif your PR uses new RPC methods or fields oflnd.