frdrpc: convert frdrpc into a go module #194
Conversation
bhandras
force-pushed
the
frdrpc-module
branch
2 times, most recently
from
cd86296
to
5c4a47b
Compare
frdrpc/go.mod
Outdated
| @@ -0,0 +1,17 @@ | |||
| module github.com/lightninglabs/faraday/frdrpc | |||
|
|
|||
| go 1.22.3 | |||
There was a problem hiding this comment.
nit: when we're touching or creating all these go.mod files, can we please also sync the place we put the version? Either all at the top or the bottom of the file? Instinctively I'd say probably at the bottom...
| github.com/lightninglabs/lndclient v0.17.4-1 | ||
| github.com/lightningnetwork/lnd v0.17.4-beta | ||
| github.com/lightningnetwork/lnd/cert v1.2.2 | ||
| github.com/lightningnetwork/lnd/kvdb v1.4.4 | ||
| github.com/shopspring/decimal v1.2.0 | ||
| github.com/stretchr/testify v1.8.4 | ||
| github.com/urfave/cli v1.22.9 | ||
| google.golang.org/grpc v1.59.0 | ||
| google.golang.org/protobuf v1.31.0 | ||
| google.golang.org/grpc v1.65.0 |
There was a problem hiding this comment.
Hmm, I'm not sure if this update might bite us, since in lnd we have an older version. Or is the plan to update that as well?
There was a problem hiding this comment.
I wouldn't think it causes any issues given Terminal compiles and runs with the frdrpc and poolrpc added as deps: lightninglabs/lightning-terminal#823 If you look closer it updates GRPC as well.
tools/Dockerfile
Outdated
| && chmod -R 777 /tmp/build/ | ||
| && go install -trimpath github.com/golangci/golangci-lint/cmd/golangci-lint \ | ||
| && chmod -R 777 /tmp/build/ \ | ||
| && git config --global --add safe.directory /build |
There was a problem hiding this comment.
I think the ENV GOFLAGS="-buildvcs=false" is the actual, preferred fix for the issue? Or did that no longer work?
There was a problem hiding this comment.
Yeah, I think I was just simply adopting the Dockerfile that we use in other lightninglabs projects. Modified to use the suggested flag instead.
tools/go.mod
Outdated
| @@ -1,9 +1,197 @@ | |||
| module github.com/lightninglabs/faraday/tools | |||
|
|
|||
| go 1.16 | |||
| go 1.21 | |||
There was a problem hiding this comment.
We might as well bump this version too...
|
@bhandras, remember to re-request review from reviewers when ready |
bhandras
force-pushed
the
frdrpc-module
branch
from
5c4a47b
to
3a3c8ca
Compare
| github.com/lightninglabs/lndclient v0.17.4-1 | ||
| github.com/lightningnetwork/lnd v0.17.4-beta | ||
| github.com/lightningnetwork/lnd/cert v1.2.2 | ||
| github.com/lightningnetwork/lnd/kvdb v1.4.4 | ||
| github.com/shopspring/decimal v1.2.0 | ||
| github.com/stretchr/testify v1.8.4 | ||
| github.com/urfave/cli v1.22.9 | ||
| google.golang.org/grpc v1.59.0 | ||
| google.golang.org/protobuf v1.31.0 | ||
| google.golang.org/grpc v1.65.0 |
There was a problem hiding this comment.
I wouldn't think it causes any issues given Terminal compiles and runs with the frdrpc and poolrpc added as deps: lightninglabs/lightning-terminal#823 If you look closer it updates GRPC as well.
frdrpc/go.mod
Outdated
| @@ -0,0 +1,17 @@ | |||
| module github.com/lightninglabs/faraday/frdrpc | |||
|
|
|||
| go 1.22.3 | |||
tools/Dockerfile
Outdated
| && chmod -R 777 /tmp/build/ | ||
| && go install -trimpath github.com/golangci/golangci-lint/cmd/golangci-lint \ | ||
| && chmod -R 777 /tmp/build/ \ | ||
| && git config --global --add safe.directory /build |
There was a problem hiding this comment.
Yeah, I think I was just simply adopting the Dockerfile that we use in other lightninglabs projects. Modified to use the suggested flag instead.
tools/go.mod
Outdated
| @@ -1,9 +1,197 @@ | |||
| module github.com/lightninglabs/faraday/tools | |||
|
|
|||
| go 1.16 | |||
| go 1.21 | |||
This commit transforms the frdrpc subpackage into a versioned module. By doing so, projects that rely solely on the generated RPC code from the proto files will benefit from significantly reduced dependencies during compilation.
Pull Request Checklist
MinLndVersionif your PR uses new RPC methods or fields oflnd.