This repository has been archived by the owner on Feb 23, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 172
Display Touch ID dialog on Android (if supported) #1312
Draft
kaloudis
wants to merge
2
commits into
lightninglabs:master
Choose a base branch
from
kaloudis:la-1200
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
mobile/android/app/src/main/java/com/lightningapp/FingerprintDialogModule.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
package com.lightningapp; | ||
|
||
import com.facebook.react.bridge.ReactApplicationContext; | ||
import com.facebook.react.bridge.ReactContextBaseJavaModule; | ||
import com.facebook.react.bridge.ReactMethod; | ||
import java.util.concurrent.Executors; | ||
import androidx.biometric.BiometricPrompt; | ||
|
||
public class FingerprintDialogModule extends ReactContextBaseJavaModule { | ||
public FingerprintDialogModule(ReactApplicationContext reactContext) { | ||
super(reactContext); //required by React Native | ||
} | ||
|
||
@Override | ||
//getName is required to define the name of the module represented in JavaScript | ||
public String getName() { | ||
return "FingerprintDialog"; | ||
} | ||
|
||
@ReactMethod | ||
public void getBiometricPrompt() { | ||
val executor = Executors.newSingleThreadExecutor(); | ||
BiometricPrompt.Builder() | ||
.setTitle("Use your fingerprint to unlock") | ||
.setSubtitle("Lightning App requires authentication to continue") | ||
.setDescription("Use your fingerprint to unlock the app or press cancel and enter in your pin") | ||
.setNegativeButton("Cancel") | ||
.build(); | ||
} | ||
} | ||
28 changes: 28 additions & 0 deletions
28
mobile/android/app/src/main/java/com/lightningapp/FingerprintDialogPackage.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
package com.lightningapp; | ||
|
||
import com.facebook.react.ReactPackage; | ||
import com.facebook.react.bridge.NativeModule; | ||
import com.facebook.react.bridge.ReactApplicationContext; | ||
import com.facebook.react.uimanager.ViewManager; | ||
import com.lightningapp.FingerprintDialogModule; | ||
|
||
import java.util.ArrayList; | ||
import java.util.Collections; | ||
import java.util.List; | ||
|
||
public class FingerprintDialogPackage implements ReactPackage { | ||
|
||
@Override | ||
public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) { | ||
return Collections.emptyList(); | ||
} | ||
|
||
@Override | ||
public List<NativeModule> createNativeModules( | ||
ReactApplicationContext reactContext) { | ||
List<NativeModule> modules = new ArrayList<>(); | ||
//this is where you register the module | ||
modules.add(new FingerprintDialogModule(reactContext)); | ||
return modules; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -192,15 +192,20 @@ class AuthAction { | |
// TouchID & KeyStore Authentication | ||
// | ||
|
||
async checkFingerprintHardwareAndEnrollment() { | ||
const hasHardware = await this._Fingerprint.hasHardwareAsync(); | ||
const isEnrolled = await this._Fingerprint.isEnrolledAsync(); | ||
return hasHardware && isEnrolled ? true : false; | ||
} | ||
|
||
/** | ||
* Try authenticating the user using either via TouchID/FaceID on iOS | ||
* or a fingerprint reader on Android. | ||
* @return {Promise<undefined>} | ||
*/ | ||
async tryFingerprint() { | ||
const hasHardware = await this._Fingerprint.hasHardwareAsync(); | ||
const isEnrolled = await this._Fingerprint.isEnrolledAsync(); | ||
if (!hasHardware || !isEnrolled) { | ||
const hasFingerprint = await this.checkFingerprintHardwareAndEnrollment(); | ||
if (!hasFingerprint) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice refactor 👍 |
||
return; | ||
} | ||
const msg = 'Unlock your Wallet'; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will likely add an error handler, (and possibly a success handler) to this file after seeing how it behaves as it.