Skip to content
This repository has been archived by the owner on Feb 23, 2021. It is now read-only.

Fix number formatting android #971

Merged
merged 4 commits into from
Feb 20, 2019
Merged

Fix number formatting android #971

merged 4 commits into from
Feb 20, 2019

Conversation

tanx
Copy link
Contributor

@tanx tanx commented Feb 13, 2019

Closes #932

@tanx tanx force-pushed the fix-number-formatting-android branch from 5700f11 to 8f15a44 Compare February 13, 2019 06:34
valentinewallace
valentinewallace approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@valentinewallace valentinewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK :) wonder if I should get an android dev phone? I'll try to set up Android Studio this week so I can test Android PRs properly.

@tanx
Copy link
Contributor Author

tanx commented Feb 20, 2019

utACK :) wonder if I should get an android dev phone? I'll try to set up Android Studio this week so I can test Android PRs properly.

I'm using an old Nexus 5X myself. /cc @bryanvu

@tanx tanx merged commit 9d50716 into master Feb 20, 2019
@tanx tanx deleted the fix-number-formatting-android branch February 20, 2019 05:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@valentinewallace valentinewallace valentinewallace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanx @valentinewallace