remove global window and localStorage dependecy #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
window and localStorage are not available in all environments. For example service workers don't have those available. The globalThis property provides a standard way of accessing the global this value across environments. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis
bumi
commented
Jan 9, 2023
| @@ -195,7 +195,11 @@ export default class LNC { | |||
| ); | |||
|
|
|||
| // add an event listener to disconnect if the page is unloaded | |||
| window.addEventListener('unload', this.wasm.wasmClientDisconnect); | |||
| if (typeof window !== "undefined") { | |||
| window.addEventListener('unload', this.wasm.wasmClientDisconnect); | |||
There was a problem hiding this comment.
here we can add an eventListener only when the window is available. other contexts might need to manually register some custom code to disconnect.
bumi
commented
Jan 9, 2023
| @@ -65,7 +65,7 @@ export default class LNC { | |||
| } | |||
|
|
|||
| private get wasm() { | |||
| return window[this._namespace] as WasmGlobal; | |||
| return globalThis[this._namespace] as WasmGlobal; | |||
There was a problem hiding this comment.
this actually looks a bit dangerous because this could overwrite something. if this._namespace is already a defined property.
|
tACK - tried with the connect demo |
kaloudis
approved these changes
Jan 18, 2023
|
Do you have an update on this? will it get in a release? ;) We use a git dependency for this right now which seems to cause some npm install issues. |
|
@bumi apologies for the delay. Cutting a new release today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window and localStorage are not available in all environments. For example service workers don't have those available (afaik).
The globalThis property provides a standard way of accessing the global this value across environments.
The wasm_exec.js code already checks if window is available.
reference:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis