Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lnc-core version and add Taproot Assets support #84

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Conversation

jamaljsr
Copy link
Member

@jamaljsr jamaljsr commented Jun 14, 2023

Updates the default WASM file url to v0.2.5-alpha and exposes the tapd API via the LNC class.

Note: CI will fail until the new version of lnc-core is published to NPM.

To test these changes:

  1. Checkout Add Taproot Assets support lnc-core#17 and run yarn && yarn link && yarn build in that repo
  2. Checkout this PR and run yarn && yarn link @lightninglabs/lnc-core && yarn build in the root of this repo
  3. Change to the demos/kitchen-sink dir and run yarn && yarn link @lightninglabs/lnc-web && yarn start. The demo site should open in your browser.
  4. Grab a pairing phrase from a litd node running the master branch since subservers: register taproot assets universe servers lightning-terminal#572 is needed for the tapd universe RPCs to work.
  5. Update demos/kitchen-sink/src/App.js with the pairing phrase
  6. In the demo site try to Connect and call listAssets to confirm the tapd RPC is functional.

@jbrill
Copy link

jbrill commented Jun 16, 2023

image
I'm getting the following error on the kitchen sink demo. Have you ran into this before?

@jamaljsr
Copy link
Member Author

Ah my bad.. I made a typo in the test instructions. In yarn && yarn link @lightninglabs/lnc-core && yarn start change lnc-core to lnc-web.

@jbrill
Copy link

jbrill commented Jun 16, 2023

Oh nice -- that works!

@jbrill
Copy link

jbrill commented Jun 16, 2023

Can confirm the RPCs are functional!

wasm [info] The WASM client is connected to the server +343ms
index.js:2 wasm [debug] taprpc.TaprootAssets.ListAssets request +3s undefined
index.js:2 2023-06-16 15:23:15.238 [INF] WASM: Calling 'taprpc.TaprootAssets.ListAssets' on RPC with request {}
index.js:2 wasm [debug] taprpc.TaprootAssets.ListAssets response +50ms {assets: Array(0)}
App.js:88 {assets: Array(0)}
index.js:2 wasm [debug] mintrpc.Mint.ListBatches request +4s undefined
index.js:2 2023-06-16 15:23:18.937 [INF] WASM: Calling 'mintrpc.Mint.ListBatches' on RPC with request {}
index.js:2 wasm [debug] mintrpc.Mint.ListBatches response +11ms {batches: Array(0)}
App.js:93 {batches: Array(0)}
index.js:2 wasm [debug] universerpc.Universe.ListFederationServers request +1s undefined
index.js:2 2023-06-16 15:23:20.106 [INF] WASM: Calling 'universerpc.Universe.ListFederationServers' on RPC with request {}
index.js:2 wasm [debug] universerpc.Universe.ListFederationServers response +31ms {servers: Array(0)}
App.js:98 {servers: Array(0)}

@jamaljsr jamaljsr changed the title Bump LNC version and add Taproot Assets support Bump lnc-core version and add Taproot Assets support Jun 22, 2023
@jamaljsr
Copy link
Member Author

lnc-core v0.2.5-alpha has been published. Updated this PR to use the package from the NPM registry.

@jamaljsr jamaljsr merged commit fa2d8a6 into main Jun 22, 2023
@jamaljsr jamaljsr deleted the add-tapd branch June 22, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants