sweepbatcher: log confirmed batch tx id #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhandras
approved these changes
Sep 2, 2024
1 task
starius
approved these changes
Sep 2, 2024
sweepbatcher/sweep_batch.go
Outdated
| @@ -1997,7 +1997,7 @@ func (b *batch) handleSpend(ctx context.Context, spendTx *wire.MsgTx) error { | |||
| // handleConf handles a confirmation notification. This is the final step of the | |||
| // batch. Here we signal to the batcher that this batch was completed. | |||
| func (b *batch) handleConf(ctx context.Context) error { | |||
| b.log.Infof("confirmed") | |||
| b.log.Infof("confirmed in txid %s", b.batchTxid.String()) | |||
There was a problem hiding this comment.
I propose to remove .String(). If for some reason batchTxid is nil, b.batchTxid.String() panics. If we pass b.batchTxid, it just prints as <nil>.
hieblmi
force-pushed
the
in-batch-logging
branch
from
2e89ec4
to
3ee3963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log confirmed batch tx ids.