Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify onion routing shared secret calculation loop and adjust term… #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arik-so
Copy link

@arik-so arik-so commented Nov 14, 2019

The loop can be started from 0 rather than from 1, and the cached blinding factor was actually the cached ephemeral private key, so I renamed the variable.

@Roasbeef
Copy link
Member

I don't think this actually simplifies things. The loop starts from 1 as we've unrolled the first iteration to live outside the main loop. The variable re-name doesn't seem correct either, as it is the running cached blinding factor. I'd recommend reading the comments again, and possibly going back in the commit history to check out what the loop looked like when we had to re-compute the blinding factor for a hop from scratch each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants