-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lnrpc: expose commitment type on pending open and waiting close channels #4129
lnrpc: expose commitment type on pending open and waiting close channels #4129
Conversation
4bb844e
to
7c5d8be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after rebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
7c5d8be
to
c17eb7e
Compare
Realizing now that for the pending close channels, the default commitment type will be displayed always. Need to fix that in some way. |
The problem is that the
@carlaKC @cfromknecht prefs? |
I think this would be my preference, moving the field (2) doesn't make sense, and (3) is more work than it's worth for a rpc change. #4111 added some information to pending channels using the historical channel bucket, I think it's ok to do the same here:
|
Yes I agree with @carlaKC, i think leaving as unknown is likely the best option at this point. Several of our recently added rpc fields take this approach when we can't backfill information. |
|
c17eb7e
to
fce7eb0
Compare
Stuck with |
fce7eb0
to
28c3e56
Compare
Nice to see the historical bucket being used now. The originally intent was for anchors, but in the end we didn't need it. |
@cfromknecht final check whether there is a better solution for the proto enum |
28c3e56
to
baffe15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Small addition so that users with waiting close channels can find out whether it makes sense to try to bump the commitment fee.
Added commit type to pending open channels as well as it was just a single line.
Pending close channels take their info from the close summary, which unfortunately doesn't provide easy access to the commit type.